Hotfix/upack existing package #14489
Conversation
|
|
|
@zhenghao104 @aasim @phil-hodgson @satbai @mihairatoiu - I was wondering if we can get an update on when this will get merged. As it is cause confusion in our publish builds. |
|
I'm also waiting on the reviewers |
|
Looking for this fix to be merged on our end as well, happy to help out in any way I can, but looks like it is still pending reviews. |
|
Approved, only the task version needs to be updated to match the current sprint. |
|
Sure, I have updated the task version |
|
Is there something else needed to do? I see that It's waiting for status on the pipelines for a couple of days... |
|
You may have to update this branch with the base branch to kick off those pipeline. |
|
I did that but I see it didn't work and it's now again out-of-date with the base branch |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 14489 in repo microsoft/azure-pipelines-tasks |
|
@zhenghao104 can you please retrigger the azure pipelines to run? I have updated to master but it didn't trigger. |
|
Retriggered |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
@mihairatoiu @tldavies @thisisbrianstewart Can this be merged? |
There was a problem hiding this comment.
Looks good, no comments to add. Did notice another issue during the review that I will open separately -- this PR correctly checks the error code with ===, but previous code used ==, and we should favor strict equality unless we expect that return type to mutate.
Reviewed and good to go on my end. |
|
@thisisbrianstewart I am not able to merge from my end. @mihairatoiu |
|
@zhenghao104 it likely requires someone who is a code owner to merge it. @aasim @phil-hodgson @satbai could you review this PR and assist? |
|
Sorry, I don't have the option to merge it. The code owners should be able to. |
|
@mihairatoiu - can you please rebase this branch with master to resolve conflicts |
|
@aasim - I have updated to current version of master and increased the version to current sprint |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Task name: UniversalPackages
Description: On existing package publish fail with error instead of success.
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: Y
#14487
Checklist: